FinanceRoutines.jl

commit e32b0eba8634bd89cd43bfa2bd11b825b40f9c09
parent 346a2892e8d8f5b1596d48f61423da12cd63a2c1
Author: Erik Loualiche <[email protected]>
Date:   Sat, 24 May 2025 22:11:30 -0500

fix a bug where selection of variable in import_msf was of type string

Diffstat:
M
src/Merge_CRSP_Comp.jl
 | 
10
+++++-----

1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/Merge_CRSP_Comp.jl b/src/Merge_CRSP_Comp.jl
@@ -262,16 +262,16 @@ function link_MSF(df_linktable::DataFrame, df_msf::DataFrame;
         by_key(:permno) & by_pred(:date, ∈, x->x.linkdt..x.linkenddt)
     )
     @p df_msf_linked |> filter!(.!ismissing.(_.gvkey))
-    col_keep = vcat([:date, :permno, :gvkey], intersect(variables, names(df_msf_linked))) |> unique
+    col_keep = vcat([:date, :permno, :gvkey], intersect(variables, propertynames(df_msf_linked))) |> unique
     select!(df_msf_linked, col_keep)
     
 # merge this back
-    df_msf_merged = leftjoin(df_msf, df_msf_linked, on = [:date, :permno], source="_merge")
-    transform!(df_msf_merged, :date => ByRow(year) => :datey)
-    select!(df_msf_merged, Not(:_merge))
+    df_msf_linked = leftjoin(df_msf, df_msf_linked, on = [:date, :permno], source="_merge")
+    transform!(df_msf_linked, :date => ByRow(year) => :datey)
+    select!(df_msf_linked, Not(:_merge))
 
 
-    return df_msf_merged
+    return df_msf_linked
 end
 # ------------------------------------------------------------------------------------------